refactor(grid): apply vanilla-extract by synuns · Pull Request #193 · sipe-team/side

synuns · 2025-07-12T08:03:47Z

Changes

css modules to vanilla extract migration

Visuals

Checklist

Have you written the functional specifications?
Have you written the test code?

Additional Discussion Points

Grid migration

changeset-bot · 2025-07-12T08:03:52Z

⚠️ No Changeset found

Latest commit: 72076d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR

Some errors occurred when validating the changesets config:
The package or glob expression "@sipe-team/package-name" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

coderabbitai · 2025-07-12T08:03:56Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-07-12T08:05:09Z

✅ Deploy Preview for side-design-system ready!

Name	Link
🔨 Latest commit	`72076d0`
🔍 Latest deploy log	https://app.netlify.com/projects/side-design-system/deploys/6874ce38bb97fc0008b30f69
😎 Deploy Preview	https://deploy-preview-193--side-design-system.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

froggy1014 · 2025-07-12T15:04:28Z

pnpm-lock.yaml

      '@radix-ui/react-slot':
        specifier: ^1.1.0
        version: 1.2.3(@types/react@18.3.23)(react@18.3.1)
+      '@vanilla-extract/css':


pnpm-lock 지우고 다시 install 해보시겠어욤 ?

froggy1014

LGTM

pnpm-lock 만 해결해주세요.

codecov · 2025-07-14T09:31:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines	Coverage Δ
packages/grid/src/Grid.css.ts	`100.00% <100.00%> (ø)`
packages/grid/src/Grid.test.tsx	`100.00% <100.00%> (ø)`
packages/grid/src/Grid.tsx	`100.00% <100.00%> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

synuns added 3 commits July 12, 2025 16:53

chore(grid): add vanilla-extract package

c40f9bf

refactor(grid): apply vanilla-extract

4560c04

Grid migration

style(grid): apply new biome lint

df0426a

synuns self-assigned this Jul 12, 2025

synuns requested review from SEMIN-97, bae-sh, developerjhp, froggy1014, heeji289, hy57in, jiji-hoon96, kimdaeyeob, noahluftyang and yeojini as code owners July 12, 2025 08:03

synuns added the enhancement New feature or request label Jul 12, 2025

synuns linked an issue Jul 12, 2025 that may be closed by this pull request

[FEATURE] Grid migration #183

Closed

synuns changed the base branch from main to release/v1 July 12, 2025 08:05

synuns requested review from dev-hobin, haedawn and leejiwonn as code owners July 12, 2025 08:05

froggy1014 reviewed Jul 12, 2025

View reviewed changes

froggy1014 approved these changes Jul 12, 2025

View reviewed changes

fix(side): delete vanilla-extract in lock file

72076d0

synuns merged commit 10b64eb into release/v1 Jul 14, 2025
8 checks passed

synuns deleted the refactor/grid-to-vx branch July 14, 2025 09:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(grid): apply vanilla-extract#193

refactor(grid): apply vanilla-extract#193
synuns merged 4 commits intorelease/v1from
refactor/grid-to-vx

synuns commented Jul 12, 2025

Uh oh!

changeset-bot bot commented Jul 12, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 12, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

netlify bot commented Jul 12, 2025 •

edited

Loading

Uh oh!

froggy1014 Jul 12, 2025

Uh oh!

froggy1014 left a comment

Uh oh!

codecov bot commented Jul 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

synuns commented Jul 12, 2025

Changes

Visuals

Checklist

Additional Discussion Points

Uh oh!

changeset-bot bot commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

netlify bot commented Jul 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for side-design-system ready!

Uh oh!

froggy1014 Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

froggy1014 left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

changeset-bot bot commented Jul 12, 2025 •

edited

Loading

coderabbitai bot commented Jul 12, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Jul 12, 2025 •

edited

Loading

codecov bot commented Jul 14, 2025 •

edited

Loading