Skip to content

docs: SIDE v2 토큰 아키텍처 및 네이밍 컨벤션 설계 문서 추가#246

Merged
3o14 merged 1 commit intodev/side-v2from
docs/#219-token-convention-wonju
Apr 21, 2026
Merged

docs: SIDE v2 토큰 아키텍처 및 네이밍 컨벤션 설계 문서 추가#246
3o14 merged 1 commit intodev/side-v2from
docs/#219-token-convention-wonju

Conversation

@3o14
Copy link
Copy Markdown
Member

@3o14 3o14 commented Apr 21, 2026

Summary

  • Primitive / Semantic 2계층 토큰 아키텍처 설계 문서 추가 (token-architecture.md)
  • 토큰 네이밍 컨벤션 문서 추가 (token-naming-convention.md)

주요 설계 결정

  • 2 layer 구조: Primitive(원시값 팔레트), Semantic(의미 기반 alias)
  • Primitive foundation 범위: Colors / Spacing / Typography / Radius
  • 다크 모드 기본값: :root에 dark values 주입, 시스템 라이트모드는 @media (prefers-color-scheme: light) + [data-mode="light"] 명시로 대응

Closes #219

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026

🦋 Changeset detected

Latest commit: 14a042a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@3o14 3o14 marked this pull request as draft April 21, 2026 14:16
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 21, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • main
  • release/v1

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 40da8a1c-34b9-4383-a063-11d2f4a450ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Updated branch naming conventions from <CATEGORY>/<ISSUENUMBER>-<SUBJECT> to <CATEGORY>/<SUBJECT>-<USERNAME>, added token architecture/naming decision documents, simplified commitlint configuration to use config-conventional, updated pnpm and commitlint dependencies, and declared CSS files as side-effectful in component packages.

Changes

Cohort / File(s) Summary
Token Architecture & Design Decisions
.github/decisions/token-architecture.md, .github/decisions/token-naming-convention.md, .github/decisions/v1-audit.md
Added three new decision documents defining Primitive/Semantic token layer structure, vanilla-extract file organization, naming schemas, theming strategy, and v1 token inventory with usage matrix.
Branch & Commit Naming Conventions
.github/CONTRIBUTING.md, .husky/pre-push, AGENTS.md, CLAUDE.md
Updated branch naming from <CATEGORY>/<ISSUENUMBER>-<SUBJECT> to <CATEGORY>/<SUBJECT>-<USERNAME> with required hyphen; expanded Conventional Commit types list; added special handling for main and dev/* branches.
Commitlint Configuration
commitlint.config.ts, package.json
Simplified commitlint config to use only extends: ['@commitlint/config-conventional'], removing custom subject validation and rule overrides; bumped @commitlint/* packages from ^19.x to ^20.x; added inquirer dependency.
Tool & Dependency Updates
.mise.toml, package.json
Upgraded pnpm from 9.7.1 to 10.33.0 in .mise.toml and package.json engines constraint.
CI Workflow Configuration
.github/workflows/ci.yaml
Added --if-present flag to pnpm filter commands for lint, test, typecheck, and build tasks, allowing skipping when scripts are undefined.
CSS Side-Effects Declaration
packages/accordion/package.json, packages/badge/package.json, packages/button/package.json, packages/card/package.json, packages/checkbox/package.json, packages/divider/package.json, packages/flex/package.json, packages/grid/package.json, packages/input/package.json, packages/radio/package.json, packages/reset/package.json, packages/side/package.json, packages/skeleton/package.json, packages/switch/package.json, packages/tooltip/package.json, packages/typography/package.json
Changed sideEffects from false to ["**/*.css"] across 16 component packages, marking CSS files as side-effectful for bundlers.
Miscellaneous Configuration
.gitignore, .vscode/extensions.json
Added .omc/ directory to .gitignore and fixed trailing newline; removed trailing comma from .vscode/extensions.json recommendations array.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

Possibly related PRs

Suggested labels

documentation

Suggested reviewers

  • kimdaeyeob
  • bae-sh
  • heeji289
  • yeojini
  • hy57in
  • SEMIN-97
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately describes the main changes: adding SIDE v2 token architecture and naming convention design documents.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/#219-token-convention-wonju

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@3o14 3o14 changed the base branch from main to dev/side-v2 April 21, 2026 14:17
@3o14 3o14 marked this pull request as ready for review April 21, 2026 14:17
@3o14
Copy link
Copy Markdown
Member Author

3o14 commented Apr 21, 2026

실제 작업 내용은 없어서 승인 대기 없이 merge 하겠습니다!

@3o14 3o14 merged commit 319a427 into dev/side-v2 Apr 21, 2026
4 checks passed
@3o14 3o14 deleted the docs/#219-token-convention-wonju branch April 21, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant