Handle nested destructuring assignment #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
sirbrillig
force-pushed
the
nested-destructuring-assignment
branch
from
5d65570 to
288d02a
Compare
sirbrillig
force-pushed
the
nested-destructuring-assignment
branch
from
288d02a to
06e8d9b
Compare
Owner
Author
|
This could even be simplified further since |
It shouldn't be able to fail since we already search for the opening bracket, but it seems to fail in CI.
This will never happen but the return type can include `true` so we must look for it to satisfy the static analysis.
The comparison with true was sometimes breaking phpstan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Props to @dlh01 in Automattic/VIP-Coding-Standards#458 who noticed the bug in a different sniff but it's totally applicable here too.
Fixes #130