Helper::areAnyConditionsAClosure(): remove unused method #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't find any use of this method anywhere in the code base anymore, so it may as well be removed.
Collaborator
Author
|
@sirbrillig Note: you may want to wait with merging this for the next major release as it could be considered a BC break. |
Owner
How's that? If it's not used... |
Collaborator
Author
Not used within this code base. But it's a |
Owner
|
Good point! But it's not part of the sniff's public API and not in the documentation, so I'd consider anyone relying on anything inside |
jrfnl
deleted the
feature/remove-unused-method-areanyconditionsaclosure
branch
Collaborator
Author
|
Fair point. Just do me a favour and do mention the removal in the changelog for the next release. |
sirbrillig
pushed a commit
that referenced
this pull request
May 25, 2020
Can't find any use of this method anywhere in the code base anymore, so it may as well be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't find any use of this method anywhere in the code base anymore, so it may as well be removed.