Composer: remove the Composer PHPCS plugin #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Dealerdirect Composer PHPCS plugin is already a (non-dev) requirement of PHPCSUtils, so will be installed whether you require it or not. By removing it from the `composer.json` file, potential conflicts between the versions allowed by PHPCSUtils and this plugin are prevented. Note: The plugin has released a new version last week and the new version of PHPCSUtils which was also released a few days back, already allows for it. The new version of the plugin includes support for Composer 2.0 and allows for testing standards with the plugin on PHP 8 and with PHPCS 4.x-dev. Ref: https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases/tag/v0.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dealerdirect Composer PHPCS plugin is already a (non-dev) requirement of PHPCSUtils, so will be installed whether you require it or not.
By removing it from the
composer.jsonfile, potential conflicts between the versions allowed by PHPCSUtils and this plugin are prevented.Note: The plugin has released a new version last week and the new version of PHPCSUtils which was also released a few days back, already allows for it. The new version of the plugin includes support for Composer 2.0 and allows for testing standards with the plugin on PHP 8 and with PHPCS 4.x-dev.
Ref: https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases/tag/v0.7.0