fix: cap websocket message buffering and remove stale websocket entries#42
Merged
CypherPotato merged 1 commit intoMay 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
HttpWebSocket.ReceiveInternalAsyncby readingrequest.baseServer.ServerConfiguration.MaximumContentLengthand treating non-positive values as unlimited (Int32.MaxValue).WebSocketCloseStatus.MessageTooBigand callsCloseAsyncwhen an in-progress fragmented message would exceed the configured maximum before writing more data into the accumulator.HttpWebSocketConnectionCollection.RegisterWebSocketto remove duplicate identified sockets from the internal_wslist before disposing them to avoid leaving stale references.HttpWebSocketConnectionCollection.DropAll()to clear_wsand then dispose the previous entries so disposed sockets are not retained in the collection.Testing
dotnet test src/Sisk.Core.csproj -v minimaland the project tests/build succeeded.dotnet testfrom the repository root fails when no solution/project file is specified, so the targeted project test was used and completed successfully.Codex Task