Fixed setting up mocks with the new firebase_core_platform_interface #6
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
=======================================
Coverage 94.11% 94.11%
=======================================
Files 4 4
Lines 85 85
=======================================
Hits 80 80
Misses 5 5 Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
Might as well move |
Done. |
- Use the latest stable flutter - Changed `runs-on` from `macos-latest` to `ubuntu-latest` to minimize actions time spent as macos minute is treated as 10 ubuntu minutes
|
@sitatec I've also updated Github Actions build script with next improvements:
|
|
Cool, that's what caused my PR to fail to build. I wanted to make similar changes, but now I'll wait for @sitatec to merge your PR. |
sitatec
left a comment
sitatec
left a comment
There was a problem hiding this comment.
Thanks for your contribution @OlegNovosad. We just need to revert one change before merging.
| test("Should get reference using the deprecated reference() method", () { | ||
| expect( | ||
| MockFirebaseDatabase.instance.reference().child("deprecated").path, | ||
| MockFirebaseDatabase.instance.ref().child("deprecated").path, | ||
| MockDatabaseReference().child("deprecated").path, | ||
| ); | ||
| }); |
There was a problem hiding this comment.
We need to revert this change. This test is for the reference method not for the ref one, the ref method has it own tests.
Although the reference method is deprecated, it hasn't been removed yet.
4 participants
Uh oh!
There was an error while loading. Please reload this page.