-
Notifications
You must be signed in to change notification settings - Fork 14
Implement get method for MockDatabaseReference #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Perhaps changing this to |
|
Thanks @Zohenn for the PR. We need to resolve one conflict to merge it. |
|
@sitatec done. I will try to implement other methods, though it needs a bit more work in order to not repeat the code. It should be done better than in this PR, so you can actually test this. I suppose you're not working on anything related to this package at the moment? |
Codecov Report
@@ Coverage Diff @@
## main #7 +/- ##
==========================================
+ Coverage 94.11% 94.94% +0.83%
==========================================
Files 4 4
Lines 85 99 +14
==========================================
+ Hits 80 94 +14
Misses 5 5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@Zohenn no, I haven't worked on something related to this package for a while. |
|
@sitatec I can do it too, will get it done today. The coverage will still decrease a bit anyway. It's just a metric after all. |
|
@sitatec Could you run Codecov now? |
|
Huge thanks man! |
|
I just published the new version to pub.dev |
Implemented
getmethod for MockDatabaseReference. This is by no means the most performant code, but it gets the job done. I basically took the existing code foronce, extracted most of it into a separate method and then used it to returnMockDataSnapshot.I added an additional test for
MockDataSnapshot, but I didn't test the new method, since it's basically the same asonce. At least as long as it supportsDatabaseEventType.valueonly.