Fix the CDP field name for render-blocking lift#158
Merged
Conversation
The lift introduced in 1.3.0 silently never fires against real Chrome. Chrome emits the per-request render-blocking classification as Network.requestWillBeSent.params.renderBlockingBehavior, not renderBlockingStatus — _renderBlocking was therefore unset on every entry, and every downstream consumer (waterfall-tools' orange ⊗ marker, sitespeed.io's request detail panel, pagexray's render-blocking counts) silently rendered nothing. The synthetic unit tests passed against the typo because they authored the input next to the assertion; a regression test against a real perflog now guards that class of mistake. Co-authored-by: Claude Opus 4.7 (1M context) noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lift introduced in 1.3.0 silently never fires against real
Chrome. Chrome emits the per-request render-blocking classification
as Network.requestWillBeSent.params.renderBlockingBehavior, not
renderBlockingStatus — _renderBlocking was therefore unset on
every entry, and every downstream consumer (waterfall-tools' orange
⊗ marker, sitespeed.io's request detail panel, pagexray's
render-blocking counts) silently rendered nothing.
The synthetic unit tests passed against the typo because they
authored the input next to the assertion; a regression test against
a real perflog now guards that class of mistake.
Co-authored-by: Claude Opus 4.7 (1M context) noreply@anthropic.com