Chromedriver modernize install#19
Merged
Merged
Conversation
Replace the node-downloader-helper runtime dep with native fetch + stream
pipeline (Node 22+). Install failures now exit non-zero with a clear
message instead of being silently logged.
The check-latest script was hitting the legacy chromedriver.storage
endpoint and parsing a version string that has had two dots in it for a
while; point it at the chrome-for-testing last-known-good-versions
endpoint and compare against chromedriver_version. While there, drop the
deprecated request dev dep and the semver dev dep (split('.') is enough
for the major/minor check in test.js).
Bumps engines.node to >=22 and the CI matrix to Node 22 to match.
Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.