Skip to content
This repository was archived by the owner on May 16, 2024. It is now read-only.

fix: noColor outputs color characters#344

Merged
soulgalore merged 1 commit intositespeedio:masterfrom
sumeetrohra:sumeetrohra/fix#126
Sep 22, 2019
Merged

fix: noColor outputs color characters#344
soulgalore merged 1 commit intositespeedio:masterfrom
sumeetrohra:sumeetrohra/fix#126

Conversation

@sumeetrohra
Copy link
Copy Markdown
Contributor

ISSUES CLOSED: #126

Your checklist for this pull request

Please review the guidelines for contributing to this repository.

  • Check that your change/fix has corresponding unit tests
  • Verify that the test works by running npm test and test linting by npm run lint
  • Squash commits so it looks sane

Description

Please describe your pull request and tell us the fix #

Thank you for helping the coach!

@sumeetrohra
Copy link
Copy Markdown
Contributor Author

The issue was with cli-tables3 library, fixed it using regex.
Output:
Screenshot from 2019-09-22 18-51-52

@soulgalore soulgalore merged commit 1e4c3c5 into sitespeedio:master Sep 22, 2019
@sumeetrohra sumeetrohra deleted the sumeetrohra/fix#126 branch October 2, 2019 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--noColor still outputs color characters

2 participants