Fix HTTP/3, Cache-Control casing, url.parse deprecation, and empty-pageref crash#128
Merged
Merged
Conversation
…geref crash A handful of small correctness fixes that surfaced while x-raying real HARs: HTTP/3 traffic was being reported as plain HTTP/1 whenever the HAR carried the canonical "HTTP/3" / "HTTP/3.0" string instead of the lowercase "h3" shorthand — so any consumer counting h3 connections undercounted them. Cache-Control directives are case-insensitive per RFC 7234, but the parser only matched lowercase. A response with "Max-Age=42" was treated as uncacheable (returned 0), which made cache-hit reporting look worse than reality. Modern Node prints a DEP0169 deprecation warning every time getHostname is called because it still used the legacy url.parse. Switching to the WHATWG URL API silences the warning and aligns with the rest of the ecosystem. Finally, getDocumentRequests crashed with "Cannot read properties of undefined" when a HAR contained a page whose pageref didn't appear in log.entries — now it just returns an empty array. Co-authored-by: Claude Opus 4.7 (1M context) noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A handful of small correctness fixes that surfaced while x-raying real HARs:
HTTP/3 traffic was being reported as plain HTTP/1 whenever the HAR carried the canonical "HTTP/3" / "HTTP/3.0" string instead of the
lowercase "h3" shorthand — so any consumer counting h3 connections undercounted them.
Cache-Control directives are case-insensitive per RFC 7234, but the parser only matched lowercase. A response with "Max-Age=42" was treated
as uncacheable (returned 0), which made cache-hit reporting look worse than reality.
Modern Node prints a DEP0169 deprecation warning every time getHostname is called because it still used the legacy url.parse. Switching to
the WHATWG URL API silences the warning and aligns with the rest of the ecosystem.
Finally, getDocumentRequests crashed with "Cannot read properties of undefined" when a HAR contained a page whose pageref didn't appear in
log.entries — now it just returns an empty array.
Co-authored-by: Claude Opus 4.7 (1M context) noreply@anthropic.com