Notifications improvements - Usability Implementation Plan by apodacaduron · Pull Request #248 · sjacorg/bayanat

apodacaduron · 2026-01-28T21:09:29Z

Description

Increase width of notification drawer
Display mark as read icon only on hover and update style of the button
Add new button to mark all notifications as read (endpoint already existed)
Change background of urgent notifications to something more subtle
Change important dialog notifications title and button label

How to Test

Trigger or create notifications with is_urgent=True and is_urgent=False so you can see the the changes to the important notifications dialog, then click the bell icon at the top to see the changes to the notifications drawer

Jira ID (if applicable)

Epic => BYNT-1532

BYNT-1533
BYNT-1534

…hange list spacing

…rk as read icon, show icon only on hover

…dialog (endpoint already existed)

coderabbitai · 2026-01-28T21:09:36Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d869a617-637c-4a81-afcc-4479fde953cd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch notifications-improvements

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…cations-improvements

level09

nice work overall, a few things to clean up before merging

…cations-improvements

level09

One bug to fix before merge.

…tatus

Three items in the v4.0.0 CHANGELOG section were inaccurate when checked against the v3.0.0 tag: - OCR section said the pipeline replaced a "Google Vision-only pipeline", but v3 had no Google Vision anywhere in the codebase. v3's OCR was an inline Tesseract helper used during PDF import. Updated to reflect the real pre-v4 state and expanded with the Extraction model, dashboard provider switching, and the Text Map overlay that actually shipped. - Notifications section claimed a "redesigned notification system with dedicated database table". enferno/admin/models/Notification.py is identical at v3.0.0 and main (226 lines, zero commits since v3). The notification table and model pre-existed v4. The only v4 change to notifications was #248, which adjusts drawer UI (hover-only mark-as-read, mark-all button, drawer width, urgent-notification color). Replaced the section with those actual changes. - Data Model section claimed actor.id_number was "converted from string to JSONB array with type tracking". It was already declared as db.Column(JSONB, default=[], nullable=False) at v3.0.0 - line-for-line identical between v3 and main. Removed the bullet. Also removed the "Notification table with email tracking" bullet (the table pre-existed v3) and added the media orphan cleanup / per-entity etag uniqueness entry from #311 which was missing.

## Summary Three items in the v4.0.0 `CHANGELOG.md` section were inaccurate when checked against the v3.0.0 tag. Correcting before we cut the release. ## The three errors ### 1. OCR pipeline framing **Before:** "Unified OCR into provider-agnostic LLM support, replacing the Google Vision-only pipeline." **Reality:** v3 had no Google Vision anywhere in the codebase. Its OCR was an inline Tesseract helper in \`enferno/data_import/utils/media_import.py\` used during PDF import. Verified by \`git grep google_vision v3.0.0\` (zero hits) and by reading the v3 media-import code path. **After:** Section now correctly describes the v3 → v4 transition (Tesseract helper → provider-agnostic pipeline) and expands with the Extraction model, dashboard provider switching (#315), and the Text Map overlay that actually shipped. ### 2. Notifications **Before:** "Redesigned notification system with dedicated database table. Email notification support with delivery tracking. Read status, urgency flags, and categorization." **Reality:** \`enferno/admin/models/Notification.py\` is **identical at v3.0.0 and main** — 226 lines, zero commits touching the file since v3.0.0. The notification table, email delivery tracking, read status, urgency flags, and categorization all pre-existed v4. The only v4 change to notifications was PR #248, which adjusted drawer UI: hover-only mark-as-read icon, mark-all button, drawer width, urgent-notification color. **After:** Replaced with an accurate one-liner describing the actual #248 changes. ### 3. Data Model — id_number JSONB conversion **Before:** "ID number types: actor \`id_number\` converted from string to JSONB array with type tracking." **Reality:** \`actor.id_number\` was already \`db.Column(JSONB, default=[], nullable=False)\` at v3.0.0. The declaration is line-for-line identical between v3 and main. The JSONB conversion happened before v3.0.0. **After:** Removed the bullet. Also removed "Notification table with email tracking" (pre-existed v3) and added the missing media orphan cleanup / per-entity etag uniqueness entry from #311. ## Verification method Every claim was checked against the v3.0.0 tag via \`git cat-file -e\`, \`git show v3.0.0:<path>\`, and file-by-file diffs between v3 and main. ## Test plan - [x] \`git diff v3.0.0..HEAD -- CHANGELOG.md\` shows only accurate entries - [x] No other files changed - [x] Doc-only change, no code impact

apodacaduron added 7 commits January 28, 2026 15:02

change notifications drawer width

f8ab510

update texts on important notifications dialog, change button look, c…

c5a0648

…hange list spacing

update urgent notification style, add new borders, change style of ma…

df1c636

…rk as read icon, show icon only on hover

implement mark all as read functionality on notifications drawer and …

ef48545

…dialog (endpoint already existed)

change text color, icon size and position

4ca9e5d

disable mark all as read if all are read

8761012

tweak icon styles for urgent notifications

3f66c56

apodacaduron self-assigned this Jan 28, 2026

apodacaduron mentioned this pull request Jan 28, 2026

Usability Implementation Plan #242

Closed

5 tasks

Merge branch 'main' of https://github.com/sjacorg/bayanat into notifi…

3806789

…cations-improvements

apodacaduron marked this pull request as ready for review February 6, 2026 16:45

apodacaduron requested a review from level09 as a code owner February 6, 2026 16:45

apodacaduron added project i labels Feb 6, 2026

apodacaduron and others added 3 commits March 5, 2026 10:25

Merge branch 'main' of https://github.com/sjacorg/bayanat into notifi…

bc60af2

…cations-improvements

add notifications settings button

109dcef

Merge branch 'main' into notifications-improvements

89f8fd3

level09 reviewed Mar 16, 2026

View reviewed changes

Comment thread enferno/static/js/mixins/notification-mixin.js

Comment thread enferno/static/js/mixins/notification-mixin.js

Comment thread enferno/templates/important_notifications_dialog.html

apodacaduron and others added 4 commits March 16, 2026 09:06

add back primary color

71b25a0

simplify parallel requests code

1610267

sync unread count after mark all read is success

a8c7898

Merge branch 'main' into notifications-improvements

cf63180

apodacaduron requested a review from level09 March 16, 2026 15:26

Merge branch 'main' of https://github.com/sjacorg/bayanat into notifi…

5c35b02

…cations-improvements

level09 requested changes Mar 31, 2026

View reviewed changes

Comment thread enferno/static/js/mixins/notification-mixin.js

apodacaduron and others added 3 commits March 31, 2026 09:25

fix missing data property from request

163cb4d

Merge branch 'main' into notifications-improvements

d676e33

fix optimistic revert in markAllAsRead: store per-notification read_s…

872719f

…tatus

level09 approved these changes Apr 1, 2026

View reviewed changes

level09 merged commit 0bfcb35 into main Apr 1, 2026
11 checks passed

level09 deleted the notifications-improvements branch April 1, 2026 12:34

level09 mentioned this pull request Apr 15, 2026

changelog: correct v4 entries to match the code #316

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Notifications improvements - Usability Implementation Plan#248

Notifications improvements - Usability Implementation Plan#248
level09 merged 19 commits intomainfrom
notifications-improvements

apodacaduron commented Jan 28, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 28, 2026 •

edited

Loading

Review skipped

Uh oh!

level09 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

level09 left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

apodacaduron commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How to Test

Jira ID (if applicable)

Uh oh!

coderabbitai bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

level09 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

level09 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

apodacaduron commented Jan 28, 2026 •

edited

Loading

coderabbitai bot commented Jan 28, 2026 •

edited

Loading