🔒️ Validate downloaded font content before writing to cache#6
Merged
Conversation
d9758ac to
48e4fb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RenderingErrorwith a clear message when content is not a valid font — no partial cache file is writtenTASKS.md: marks gradient/grain features done, removes the GrainLayer tasks that were droppedTest plan
test_should_raise_error_when_font_data_is_not_a_valid_font— non-font bytes raiseRenderingErrortest_should_not_write_cache_file_when_font_data_is_invalid— cache dir stays empty on bad inputtest_should_accept_valid_font_magic_bytes(parametrized × 6) — all valid signatures acceptedhttps://claude.ai/code/session_01UCAexPKGo4yjaf3cMNVwGG