Fix color tuple JSON round-trip in BackgroundLayer#7
Merged
Conversation
RGB/RGBA tuples stored in BackgroundLayer.color were serialized as JSON
arrays (e.g. [255, 87, 51]) instead of hex strings ("#FF5733"), making
the output non-spec-compliant and breaking interoperability with external
consumers that expect hex color strings.
Added a field_serializer on BackgroundLayer.color that converts tuples to
uppercase hex strings on serialization. from_json continues to accept the
hex output, completing the round-trip.
https://claude.ai/code/session_01RFcfvNpAKSAqYFX8FqpnD9
…nge validation - test: extend serialization test with from_json round-trip assertion confirming tuple colors deserialise as hex strings, not tuples - fix: wrap os.remove(stale_cache) in try/except OSError so a locked/read-only file on Windows doesn't crash with an unexpected error - fix: validate that each channel in a tuple color is an int in 0–255; previously (256, 0, 0) was accepted and silently produced a malformed hex string in the serialiser https://claude.ai/code/session_01RFcfvNpAKSAqYFX8FqpnD9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RGB/RGBA tuples stored in BackgroundLayer.color were serialized as JSON
arrays (e.g. [255, 87, 51]) instead of hex strings ("#FF5733"), making
the output non-spec-compliant and breaking interoperability with external
consumers that expect hex color strings.
Added a field_serializer on BackgroundLayer.color that converts tuples to
uppercase hex strings on serialization. from_json continues to accept the
hex output, completing the round-trip.
https://claude.ai/code/session_01RFcfvNpAKSAqYFX8FqpnD9