You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An easy transition internally to storing the primary and secondary text values as CharSequence will allow the library to expose methods for setting the text values with rich text. This provides the ability to add some subtle spans on a CharSequence to better integrate with the feature being revealed.
I don't know what kind of bandwidth you maintainers have to look at pull requests. So I'm not trying to push too hard, but wanted to find out if this was inline with your vision of the library? Perhaps you'd rather it was implemented differently?
Thanks for your pull request, I have had a brief look at the changes and they look good. I plan to properly review and test the changes in the next couple of days. The changes are inline with the vision for the library. Primarily the library should follow the Material Design Guidelines on Tap Targets but with features to allow developers to tailor the Tap Targets to their requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An easy transition internally to storing the primary and secondary text values as CharSequence will allow the library to expose methods for setting the text values with rich text. This provides the ability to add some subtle spans on a CharSequence to better integrate with the feature being revealed.
There was a minor defect in the sample.