Skip to content

Support for CharSequence when setting the Primary and Secondary Text#82

Merged
sjwall merged 2 commits intosjwall:masterfrom
jwmach1:char_sequence
Aug 31, 2017
Merged

Support for CharSequence when setting the Primary and Secondary Text#82
sjwall merged 2 commits intosjwall:masterfrom
jwmach1:char_sequence

Conversation

@jwmach1
Copy link
Copy Markdown
Contributor

@jwmach1 jwmach1 commented Aug 27, 2017

An easy transition internally to storing the primary and secondary text values as CharSequence will allow the library to expose methods for setting the text values with rich text. This provides the ability to add some subtle spans on a CharSequence to better integrate with the feature being revealed.

There was a minor defect in the sample.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #82 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #82     +/-   ##
===========================================
+ Coverage     61.23%   61.43%   +0.2%     
  Complexity       49       49             
===========================================
  Files             3        3             
  Lines           761      765      +4     
  Branches        130      130             
===========================================
+ Hits            466      470      +4     
  Misses          226      226             
  Partials         69       69
Impacted Files Coverage Δ Complexity Δ
...terialtaptargetprompt/MaterialTapTargetPrompt.java 61.87% <100%> (+0.2%) 42 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7685fe...5466e38. Read the comment docs.

@jwmach1
Copy link
Copy Markdown
Contributor Author

jwmach1 commented Aug 29, 2017

I don't know what kind of bandwidth you maintainers have to look at pull requests. So I'm not trying to push too hard, but wanted to find out if this was inline with your vision of the library? Perhaps you'd rather it was implemented differently?

@sjwall
Copy link
Copy Markdown
Owner

sjwall commented Aug 29, 2017

Thanks for your pull request, I have had a brief look at the changes and they look good. I plan to properly review and test the changes in the next couple of days. The changes are inline with the vision for the library. Primarily the library should follow the Material Design Guidelines on Tap Targets but with features to allow developers to tailor the Tap Targets to their requirements.

@sjwall sjwall self-requested a review August 29, 2017 20:29
@sjwall sjwall merged commit efe2fbe into sjwall:master Aug 31, 2017
@jwmach1 jwmach1 deleted the char_sequence branch August 31, 2017 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants