Skip to content

makes it compile under rust 1.33.0#4

Merged
skade merged 1 commit intoskade:masterfrom
filiplajszczak:master
Mar 7, 2019
Merged

makes it compile under rust 1.33.0#4
skade merged 1 commit intoskade:masterfrom
filiplajszczak:master

Conversation

@filiplajszczak
Copy link
Contributor

I have no idea what am I doing ¯_(ツ)_/¯

@skade
Copy link
Owner

skade commented Mar 7, 2019

Huh, this is interesting. As the ncurses version didn't change, that should still compile...

@filiplajszczak
Copy link
Contributor Author

I was getting something like:

error: use of extern static is unsafe and requires unsafe function or block (error E0133)
  --> src/bin/sl.rs:58:26
   |
58 |         let paint_len = (ncurses::COLS - x) as usize;
   |                          ^^^^^^^^^^^^^
   |
   = note: #[deny(safe_extern_statics)] on by default
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #36247 <https://github.com/rust-lang/rust/issues/36247>
   = note: extern statics are not controlled by the Rust type system: invalid data, aliasing violations or data races will cause undefined behavior

@skade
Copy link
Owner

skade commented Mar 7, 2019

Right, so this seems to be a legit Rust bug now fixed. Thanks for submitting! :)

@skade skade merged commit 245f28a into skade:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants