Update make 4.2 -> 4.3#34
Closed
HuangShumin wants to merge 1 commit intoskeeto:masterfrom
HuangShumin:patch-1
Closed
Update make 4.2 -> 4.3#34HuangShumin wants to merge 1 commit intoskeeto:masterfrom HuangShumin:patch-1
HuangShumin wants to merge 1 commit intoskeeto:masterfrom
HuangShumin:patch-1
Conversation
request to update make version
Owner
|
Upgrading requires updating the hash as well. I just pushed a branch that
does this, make-4.3 (currently 2c1946f). Cross compilation is broken in
GNU Make 4.2, so I had a hack to fix it (-Iglob). That seems to be fixed,
so the hack should be removed, too.
Unfortunately GNU Make 4.3 is incompatible with Mingw-w64, so this still
does not work. Otherwise I would have done it already. This version makes
assumptions about fcntl() and dirent that don't hold in Mingw-w64, and so
the build fails. (See my notes in the commit.) It would probably take
substantial patching to fix.
It's quite possible that w64devkit will forever have GNU Make 4.2. "The
devil you know" and all that. It's a feature-complete mature program, and
there is practically no innovation happening in this space. The only
significant future improvements would be better Windows support (e.g.
learning how to deal with PowerShell for SHELL, and its limitations). More
likely I'd replace it altogether with a different make that has reasonable
GNU Make compatibility, enough to work with existing, real world GNU
Makefiles (in Vim, Putty, zlib, etc.).
|
Owner
|
GNU Make 4.4 recently came out, and this version seems to work well on Windows, so I've merged it as 1000d8e. (The new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
request to update make version