refactor(agent): remove injection metric logs

[skevetter]

• refactor(agent): remove injection metric logs
• fix: remove redundant logging

Summary by CodeRabbit

• Refactor
  • Simplified binary acquisition method signature
  • Removed metrics collection capability from agent injection process
  • Updated error handling to use typed stage identifiers for improved clarity

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR removes metrics collection infrastructure from the agent injection flow and modifies the BinaryManager API to return only a binary reader and error, eliminating the source name return value. It introduces a typed InjectStage constant system to replace string stage literals in error handling.

Changes

Cohort / File(s)	Summary
BinaryManager API simplification pkg/agent/binary.go	Modified AcquireBinary return signature from (io.ReadCloser, string, error) to (io.ReadCloser, error), removing the SourceName return value.
Metrics removal and stage typing pkg/agent/inject.go	Removed metrics collection scaffolding (InjectionMetrics, MetricsCollector, LogMetricsCollector) and the InjectOptions.MetricsCollector field. Added typed InjectStage constant system with three stages (Inject, CommandExecution, VersionCheck). Changed InjectError.Stage field from string to InjectStage type. Simplified injectContext struct by removing attempt and metrics fields. Updated error handling and version check flow to operate without metrics tracking.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• refactor(agent): move retry logic and binary management to binary.go #445: Directly related—this PR removes the SourceName string return from AcquireBinary that PR #445 previously added, reversing the API change.
• refactor(agent): replace custom retry logic with Kubernetes backoff strategy #446: Modifies the same files (pkg/agent/binary.go and pkg/agent/inject.go) with overlapping changes to injection and binary loading flow.
• refactor(agent): clean up InjectOptions struct and improve default handling #444: Related through injection area changes—both PRs modify InjectError and error handling in the injection flow, though this PR removes metrics while that PR works with InjectionMetrics.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'refactor(agent): remove injection metric logs' accurately describes the main change: removal of metrics collection and related logging from the agent injection flow.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch remove-inject-metrics

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}