fix: check shipped skills before doc resolution fallback#48
Conversation
Packages that ship their own skills (skills-npm convention) but have no GitHub repo or docs URLs were incorrectly falling through to the "not found" error path. Move the shipped skills check before the fallback so these packages resolve successfully. Fixes both single and parallel sync paths.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Add registryVersion to ResolveResult so shipped skills fallback doesn't need to regex-parse human readable log messages.
❓ Type of change
📚 Description
Packages that ship their own skills (skills-npm convention) but lack a GitHub repository URL or discoverable docs were falling through to the "not found" error path, showing misleading "Did you mean?" suggestions. This moves the shipped skills check before the fallback so these packages resolve successfully without needing doc resolution to succeed.
Fixes both
sync.ts(single package) andsync-parallel.ts(batch) paths.