Skip to content

fix: check shipped skills before doc resolution fallback#48

Merged
harlan-zw merged 2 commits intomainfrom
worktree-fix-shipped-skills-no-github
Mar 24, 2026
Merged

fix: check shipped skills before doc resolution fallback#48
harlan-zw merged 2 commits intomainfrom
worktree-fix-shipped-skills-no-github

Conversation

@harlan-zw
Copy link
Copy Markdown
Collaborator

❓ Type of change

  • 🐞 Bug fix

📚 Description

Packages that ship their own skills (skills-npm convention) but lack a GitHub repository URL or discoverable docs were falling through to the "not found" error path, showing misleading "Did you mean?" suggestions. This moves the shipped skills check before the fallback so these packages resolve successfully without needing doc resolution to succeed.

Fixes both sync.ts (single package) and sync-parallel.ts (batch) paths.

Packages that ship their own skills (skills-npm convention) but have
no GitHub repo or docs URLs were incorrectly falling through to the
"not found" error path. Move the shipped skills check before the
fallback so these packages resolve successfully.

Fixes both single and parallel sync paths.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 24, 2026

Warning

Rate limit exceeded

@harlan-zw has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 14 minutes and 35 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4f01d86f-e2b7-47b0-bdc8-058276ecb706

📥 Commits

Reviewing files that changed from the base of the PR and between 4cc9c99 and c9ed495.

📒 Files selected for processing (4)
  • src/commands/sync-parallel.ts
  • src/commands/sync.ts
  • src/sources/npm.ts
  • src/sources/types.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch worktree-fix-shipped-skills-no-github

Comment @coderabbitai help to get the list of available commands and usage tips.

Add registryVersion to ResolveResult so shipped skills fallback
doesn't need to regex-parse human readable log messages.
@harlan-zw harlan-zw merged commit fac44f5 into main Mar 24, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant