This repository was archived by the owner on Mar 24, 2025. It is now read-only.
refactor: websocket subscription creation#12
Merged
Conversation
added 2 commits
January 18, 2024 15:36
aljo242
requested review from
Eric-Warehime,
davidterpay and
g3ndo9kar9
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 72.36% 72.36% -0.01%
==========================================
Files 105 105
Lines 5577 5583 +6
==========================================
+ Hits 4036 4040 +4
- Misses 1282 1284 +2
Partials 259 259 ☔ View full report in Codecov by Sentry. |
davidterpay
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes BLO-778
Allow for multiple creation messages to be created and queued for providers who do not allow for all CPs to be subscribed to in one message.