URL directory hints#121
Draft
dfabulich wants to merge 3 commits intoskiptools:mainfrom
Draft
Conversation
1. Fixed `CharacterSet.urlHostAllowed`, `urlPathAllowed`, and `urlQueryAllowed`, all of which mismatched native Swift 2. `URLComponents.string` returned an unencoded query string, which `java.net.URI` failed to parse, forcing us into a fallback where we re-encoded the items and passed them to OkHttp, which stripped out `%0A` newlines. Now, we add percent encoding in `URLComponents.string`, so no fallback is necessary.
Contributor
Author
|
|
dfabulich
force-pushed
the
url-directory-hints
branch
2 times, most recently
from
c2649c3 to
6faaba8
Compare
Fixes skiptools#120 While testing it, I discovered a lot of bizarre legacy behavior that I tried to copy as best I could, e.g. for directories, `.path` returns `/foo` but `absoluteString` returns `file:///foo/`. I've also kept Skip's existing behavior not to use the legacy `.checkFileSystem` behavior by default for the deprecated legacy `init(fileURLWithPath:)` constructor and `appendingPathComponent(_:)` methods. For now, they use `.inferFromPath` by default instead.
dfabulich
force-pushed
the
url-directory-hints
branch
from
6faaba8 to
21276f4
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a stacked PR
mailto:URL encoding #113Fixes #120
While testing it, I discovered a lot of bizarre legacy behavior that I tried to copy as best I could, e.g. for directories,
.pathreturns/foobutabsoluteStringreturnsfile:///foo/.I've also kept Skip's existing behavior not to use the legacy
.checkFileSystembehavior by default for the deprecated legacyinit(fileURLWithPath:)constructor andappendingPathComponent(_:)methods. For now, they use.inferFromPathby default instead.Skip Pull Request Checklist:
swift testCursor generated a lot of tests, and a lot of bad code, which I mostly rewrote. The tests confirm that the behavior here matches native Swift Foundation.