`ToolbarItem` `Button` should render as M3 `TextButton` or `IconButton`

[dfabulich]

Today, ToolbarItem Button renders in buttonStyle(.default), i.e. we just make them clickable. This means that for text-only buttons, their ripple rectangle is tightly wrapped around their text.

It would be great if these could be TextButtons instead.

Here it is as a TextButton

When you tap down and hold, it has a nice ripple background:

[dfabulich]

I experimented with just doing this automatically for all toolbar items. It's almost an across-the-board improvement, but for image-based buttons, (which are already slightly too small on Android IMO) they should probably be implemented with IconButton (with a circular ripple instead of a capsule).

(But… how would that work, exactly? Would we compose the ToolbarItem content, inspect it, and then decide whether to embed it in a TextButton or an IconButton…??)

For my part, instead of fixing this in a systemic way, I'm now just being very careful to use .buttonStyle(.m3Text) on all of my text-only toolbar buttons, and to wire up IconButton on my icon buttons. That just kinda sucks.

[hjJunior]

Hi @dfabulich I'm looking for a soluition for this too, I trited to use composable, but no lucky on it, it seems that u was able to do it by using .buttonStyle(.m3Text), but I cannot use it

[dfabulich]

.m3Text is something I just made up as part of an open PR #406.

Once that PR merges and there's a new release of skip-ui, you'll be able to use it then.

If you want an early peek, you could update your Package.swift to use .package(url: "https://github.com/dfabulich/skip-ui", branch: "m3-text-buttons") (and then remember to change it back later)

Alternately, instead of any of that, you could use TextButton today in your ToolbarItems using ComposeView.

.m3Text will be more convenient than ComposeView once #406 merges.

[marcprux]

skip-ui 1.53.0 was just tagged, so you should be able to update and use it now.