Add sheet presentation detent & item parameter#37
Conversation
|
Thank you for your pull request and welcome to the Skip community. We require contributors to sign our contributor license agreement (CLA), and we don't seem to have the user(s) @Louis-PAGNIER on file. In order for us to review and merge your code, for each noted user please add your GitHub username to Skip's .clabot file |
|
Also, do you know how to implement the "tap outside the sheet to dismiss" behaviour like in SwiftUI ? |
|
This looks great! I'll experiment with it later today in the Showcase app's SheetPlayground and see if I can figure out the tap to dismiss, and likely merge it a bit later. Thanks for the contribution! |
|
This looks good in my testing.
I looked into how to dismiss the Unfortunately, this would probably require some significant refactoring. @aabewhite might be able to provide more insight, but for the time being, you'll be limited to dismissing the sheet either by swiping it down, or adding some "Dismiss" button in the sheet itself. |
|
No problem, it's not currently very important. |
|
Thank again for the PR. Please keep them coming! I've released skip-ui 0.9.6 with the new |

I added small support for
.presentationDetents([])with sheets.Currently only support zero or one detent in the detents list.
This commit also add support for item binding in sheet and fullScreenCover.
It is one of my first pull requests, I'm new to SwiftUI and I don't know anything about Kotlin and Compose, so tell me if anything I made is bad or wrongly implemented.