Improve image loading performance#415
Merged
Merged
Conversation
1. We'd configured Coil to load images at their original size, but Coil refuses to use its memory cache when you do that. Now, we're passing it an arbitrary size, and it's magically happy with that. 2. We're now remembering the `ImageRequest` model, ensuring its stability for recomposition
Member
|
Great improvement, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageRequestmodel, ensuring its stability for recompositionBefore this PR, skiptools/skipapp-showcase#78 was loading each SVG and decoding it as you scroll, on every frame. ☠️
Skip Pull Request Checklist:
swift testNot required
Create a view with 600 copies of the same SVG (stress test) skipapp-showcase#78
Cursor generated the code, once I figured out that it was never using its memory cache. I tested it with skiptools/skipapp-showcase#78