Skip to content

Upgrade AGP to 8.13.2 to support Kotlin 2.3#16

Closed
dfabulich wants to merge 1 commit intoskiptools:mainfrom
dfabulich:fix-r8
Closed

Upgrade AGP to 8.13.2 to support Kotlin 2.3#16
dfabulich wants to merge 1 commit intoskiptools:mainfrom
dfabulich:fix-r8

Conversation

@dfabulich
Copy link
Copy Markdown

https://developer.android.com/build/kotlin-support says that Kotlin 2.3 requires AGP 8.13.2 or later.

Fixes skiptools/skip#658

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

Cursor tracked this down for me. The only testing I did was to confirm that skiptools/skip#658 is fixed with it. (It's not at all clear to me how best to regression test AGP upgrades!)

@marcprux
Copy link
Copy Markdown
Member

marcprux commented Apr 7, 2026

(It's not at all clear to me how best to regression test AGP upgrades!)

You can just add a specific branch in your dependencies in the app's Package.swift:

    dependencies: [
        .package(url: "https://source.skip.tools/skip.git", from: "1.8.4"),
        .package(url: "https://source.skip.tools/skip-unit.git", branch: "agp-bump"),
        .package(url: "https://source.skip.tools/skip-ui.git", from: "1.0.0"),
        .package(url: "https://source.skip.tools/skip-foundation.git", from: "1.0.0"),
        .package(url: "https://source.skip.tools/skip-model.git", from: "1.0.0")
    ],

You don't actually need to reference the skip-unit dependency, but the explicit branch specification will override the transitive dependency from skip-lib (via skip-foundation).

@marcprux
Copy link
Copy Markdown
Member

marcprux commented Apr 7, 2026

Thanks for the fix. I'll close this in favor of #17, which has a little bit more doc and discussion.

@marcprux marcprux closed this Apr 7, 2026
@marcprux
Copy link
Copy Markdown
Member

marcprux commented Apr 7, 2026

(It's not at all clear to me how best to regression test AGP upgrades!)

You can just add a specific branch in your dependencies in the app's Package.swift:

nvm the last response, I see that wasn't the question you were asking.

There isn't any good way that I know of to test new AGP versions, short of exercising it by building a bunch of apps (which we do in the schedule workflows in the various skipapp- packages).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fresh project fails to R8 minify

2 participants