Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support building skip for Homebrew formula distribution (Homebrew/homebrew-core#276091), we need to build against glibc 2.27, which doesn't define
posix_spawn_file_actions_addchdir_np(added in glibc 2.29), and so was causing the build to fail for Homebrew/homebrew-core#276075:Other solutions to this (like swiftlang/swift-tools-support-core#113) will check for
__GLIBC_PREREQ(2, 29), but we'd need to do that in a .c file and we don't especially want an extra C module in this package just to handle this. Similarly we could also just rely on https://github.com/swiftlang/swift-subprocess, but we don't want the plugin to have this extra dependency just to change the directly. Lastly, we might re-implement this withchdir(like in swiftlang/swift-tools-support-core#449), but that's process-wide and so dangerous and racy.So for the time being, we'll just block out Linux and ignore the
workingDirectoryparameter, which we are mostly avoiding anyway (e.g., see skiptools/skipstone@2bba807 where we launchzipmanually with/bin/sh -c …rather than try to use the workingDirectory param).