Skip to content

fix(fe): revise qna detail page#3057

Merged
sONg20NOW merged 16 commits intomainfrom
t2068-modify-qna-detail-page
Aug 30, 2025
Merged

fix(fe): revise qna detail page#3057
sONg20NOW merged 16 commits intomainfrom
t2068-modify-qna-detail-page

Conversation

@sONg20NOW
Copy link
Copy Markdown
Contributor

@sONg20NOW sONg20NOW commented Aug 28, 2025 •
edited by ojongii
Loading

Description

8월 29일 유자차 Qna 페이지 QA에서 발견된 오류들을 수정합니다.

Additional context

  • username을 모두 변환 없이
  • Qna 생성시간 통일
  • 댓글 내용 -> 영타 시 자동 줄바꿈 안됨.
  • ongoing이 아닌 qna의 경우 다른 유저도 댓글을 달 수 있도록.
  • 버튼 디자인 변경
  • 디테일 페이지에서 Problem 카테고리의 qna에 대해 말머리에 [A. 문제 제목] 형식으로 오도록 변경

closes TAS-2068

Before submitting the PR, please make sure you do the following

@sONg20NOW sONg20NOW requested review from Clover229 and ojongii August 28, 2025 17:36
@sONg20NOW sONg20NOW self-assigned this Aug 28, 2025
@sONg20NOW sONg20NOW added ⛳️ team-frontend 🍊squad-유자차 스쿼드 유자차 작업물입니다 labels Aug 28, 2025
@github-project-automation github-project-automation Bot moved this to Pending ✋ in Codedang Aug 28, 2025
@notion-workspace
Copy link
Copy Markdown

notion-workspace Bot commented Aug 28, 2025

modify Qna detail page - 1차 QA 반영

@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 28, 2025

✅ Syncing Preview App Succeeded

Application: frontend
Revision: 355d345a48da06552523445e348967b6fd4c24e3
Health Status: Healthy

Open Preview | View in Argo CD

Clover229
Clover229 reviewed Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Clover229 Clover229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr 내용만 보고 올립니다!!
notOngoing 문제의 경우 디테일 페이지에 Problem이 아닌 특정 문제가 뜨도록? (General? Problem?)
-> upcoming 일 경우에는 어차피 general 만 가능하고, finished인 경우에는 모든 질문이 공개되니까, 디테일 페이지는 [문제 타이틀] 이렇게 그냥 바꿔도 되지 않을까요?

@sONg20NOW
Copy link
Copy Markdown
Contributor Author

sONg20NOW commented Aug 29, 2025

pr 내용만 보고 올립니다!! notOngoing 문제의 경우 디테일 페이지에 Problem이 아닌 특정 문제가 뜨도록? (General? Problem?) -> upcoming 일 경우에는 어차피 general 만 가능하고, finished인 경우에는 모든 질문이 공개되니까, 디테일 페이지는 [문제 타이틀] 이렇게 그냥 바꿔도 되지 않을까요?

아하! 지금 봤네요!! 알겠습니다~ 종희님 코드 참고해서 수정했습니다!

@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 29, 2025

✅ Syncing Preview App Succeeded

Application: frontend
Revision: f098f15d0aa4809d78581968145390f6324769dc
Health Status: Healthy

Open Preview | View in Argo CD

@sONg20NOW sONg20NOW requested a review from Clover229 August 29, 2025 04:47
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 29, 2025

✅ Syncing Preview App Succeeded

Application: frontend
Revision: 4d2fc812e2008e63638579279df1ef05a9cc8eee
Health Status: Healthy

Open Preview | View in Argo CD

@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 29, 2025

✅ Syncing Preview App Succeeded

Application: frontend
Revision: 67769ea31bd743f0f0d1b045cd3cfb0574ffddcd
Health Status: Healthy

Open Preview | View in Argo CD

@skkuding-bot

This comment was marked as outdated.

Sign in to view
Clover229
Clover229 reviewed Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Clover229 Clover229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프리뷰가 이상해요...contest 대회가 안불러와지네요 ㅠㅠ

@sONg20NOW
Copy link
Copy Markdown
Contributor Author

sONg20NOW commented Aug 29, 2025

프리뷰가 이상해요...contest 대회가 안불러와지네요 ㅠㅠ

엥 그러게요..?

@skkuding-bot

This comment was marked as outdated.

Sign in to view
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 29, 2025

✅ Syncing Preview App Succeeded

Application: frontend
Revision: d3a5b28c1f6e36054e5a8c8bb3b07125d3957dbd
Health Status: Healthy

Open Preview | View in Argo CD

Clover229
Clover229 approved these changes Aug 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Clover229 Clover229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기능들 다 확인했습니다 문제 없어보입니다~

@github-project-automation github-project-automation Bot moved this from Pending ✋ to Approved 👌 in Codedang Aug 30, 2025
@sONg20NOW sONg20NOW requested a review from ojongii August 30, 2025 12:59
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 30, 2025

✅ Syncing Preview App Succeeded

Application: frontend
Revision: d3a5b28c1f6e36054e5a8c8bb3b07125d3957dbd
Health Status: Healthy

Open Preview | View in Argo CD

ojongii
ojongii approved these changes Aug 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ojongii ojongii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 사항들 잘 반영된 것 같습니다!

@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 30, 2025

✅ Syncing Preview App Succeeded

Application: frontend
Revision: d39caa1024e6e7d476bdc8b652133e6ea794b8b8
Health Status: Healthy

Open Preview | View in Argo CD

@sONg20NOW sONg20NOW added this pull request to the merge queue Aug 30, 2025
Merged via the queue into main with commit ff5f1ae Aug 30, 2025
10 checks passed
@sONg20NOW sONg20NOW deleted the t2068-modify-qna-detail-page branch August 30, 2025 14:04
@github-project-automation github-project-automation Bot moved this from Approved 👌 to Done ✔️ in Codedang Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Clover229 Clover229 Clover229 approved these changes

@ojongii ojongii ojongii approved these changes

Assignees

@sONg20NOW sONg20NOW

Labels

🍊squad-유자차 스쿼드 유자차 작업물입니다 ⛳️ team-frontend

Projects

Codedang
Status: Done ✔️

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sONg20NOW @Clover229 @ojongii