Skip to content

feat(fe): add notification settings#3093

Merged
jwoojin9 merged 5 commits intomainfrom
t2087-add-notification-in-settings
Aug 30, 2025
Merged

feat(fe): add notification settings#3093
jwoojin9 merged 5 commits intomainfrom
t2087-add-notification-in-settings

Conversation

@jwoojin9
Copy link
Copy Markdown
Contributor

@jwoojin9 jwoojin9 commented Aug 30, 2025

Description

notification 설정을 추가합니다
image

closes TAS-2087

Additional context


Before submitting the PR, please make sure you do the following

@jwoojin9 jwoojin9 self-assigned this Aug 30, 2025
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 30, 2025

Syncing Preview App Succeeded

Application: frontend
Revision: 08db1d1dd939faf9e2b25d57737998f505127848
Health Status: Healthy

Open Preview | View in Argo CD

@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 30, 2025

Syncing Preview App Succeeded

Application: frontend
Revision: b8932b2e7c6987df4fcad2ea65c6568c600e22b5
Health Status: Healthy

Open Preview | View in Argo CD

1 similar comment
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 30, 2025

Syncing Preview App Succeeded

Application: frontend
Revision: b8932b2e7c6987df4fcad2ea65c6568c600e22b5
Health Status: Healthy

Open Preview | View in Argo CD

@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 30, 2025

Syncing Preview App Succeeded

Application: frontend
Revision: 52372da64e14447c04cee19c00808a5613fceb52
Health Status: Healthy

Open Preview | View in Argo CD

Copy link
Copy Markdown
Contributor

@w0uldy0u w0uldy0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

여기 UI가 좀... 그런게
세부 항목(?)인 "Receive~assignments"가 카테고리 제목인 "Push Notifications"보다 폰트가 크고
구분선이나 뭐 하나 없이 그 둘이 엄청 가깝고
설명과 토글이 있는 줄은 또 엄청 가로로 길고..
디자인에 조예가 없어 잘표현은 못하겠지만 문제가 좀 있어보여요

그냥 먼가 좀 사실 그냥 settings 페이지 자체 디자인이 근본적으로 문제인거 같긴한데
사실 우리 지금 알림이 Assignment관련만 오는것도 아니고 contest, notice도 오니까 그냥 저 설명 아예 빼버리고

Push Notifications 바로 밑에 토글하나만 두는건 어떨까요?

@github-project-automation github-project-automation Bot moved this from Pending ✋ to In Progress 🏃 in Codedang Aug 30, 2025
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 30, 2025

Syncing Preview App Succeeded

Application: frontend
Revision: 899b9922a43b46cdea50337ff9e38b11684e912a
Health Status: Healthy

Open Preview | View in Argo CD

Copy link
Copy Markdown
Contributor

@w0uldy0u w0uldy0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🦭✨(진짜임)

@github-project-automation github-project-automation Bot moved this from In Progress 🏃 to Approved 👌 in Codedang Aug 30, 2025
@jwoojin9 jwoojin9 added this pull request to the merge queue Aug 30, 2025
@jwoojin9 jwoojin9 removed this pull request from the merge queue due to a manual request Aug 30, 2025
@jwoojin9 jwoojin9 added this pull request to the merge queue Aug 30, 2025
Merged via the queue into main with commit 4ea3535 Aug 30, 2025
10 checks passed
@jwoojin9 jwoojin9 deleted the t2087-add-notification-in-settings branch August 30, 2025 16:54
@github-project-automation github-project-automation Bot moved this from Approved 👌 to Done ✔️ in Codedang Aug 30, 2025
@notion-workspace
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done ✔️

Development

Successfully merging this pull request may close these issues.

2 participants