Skip to content

feat(fe): adjust alert modal size#3096

Merged
w0uldy0u merged 4 commits intomainfrom
t2092-adjust-alert-modal-size
Aug 31, 2025
Merged

feat(fe): adjust alert modal size#3096
w0uldy0u merged 4 commits intomainfrom
t2092-adjust-alert-modal-size

Conversation

@w0uldy0u
Copy link
Copy Markdown
Contributor

@w0uldy0u w0uldy0u commented Aug 30, 2025

Description

모달 사이즈 수정
image

image image image

Additional context


Before submitting the PR, please make sure you do the following

Closes TAS-2092

@notion-workspace
Copy link
Copy Markdown

@w0uldy0u w0uldy0u changed the title chore(fe): correct a typo feat(fe): adjust alert modal size Aug 30, 2025
@w0uldy0u w0uldy0u requested a review from minngyuseong August 30, 2025 11:50
@w0uldy0u w0uldy0u self-assigned this Aug 30, 2025
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 30, 2025

Syncing Preview App Succeeded

Application: frontend
Revision: 5a96607a721fd78a2f5c7758daf7a5e41bd33539
Health Status: Healthy

Open Preview | View in Argo CD

@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 30, 2025

Syncing Preview App Succeeded

Application: frontend
Revision: 5a96607a721fd78a2f5c7758daf7a5e41bd33539
Health Status: Healthy

Open Preview | View in Argo CD

@jwoojin9
Copy link
Copy Markdown
Contributor

최근 PR 6개가 전부 프론트인데 그냥 넘어오시죠😂

Copy link
Copy Markdown
Contributor

@minngyuseong minngyuseong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스크린샷에 올려주신 course code 검증 모달은 원래 체크아이콘이 없는 다자인인데
#3047
이 PR에서 제가 아이콘이 기본적으로 나오도록 설정했나봐요.
다름 스크린샷에 있는 showIcon을 false로 바꾸면 auto 없이도 해결될것 같습니다
image

Comment thread apps/frontend/components/AlertModal.tsx Outdated
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 31, 2025

Syncing Preview App Succeeded

Application: frontend
Revision: 84e146ac91c542032529b09f289547a9890a3f91
Health Status: Healthy

Open Preview | View in Argo CD

@w0uldy0u w0uldy0u requested a review from minngyuseong August 31, 2025 06:34
Copy link
Copy Markdown
Contributor

@minngyuseong minngyuseong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@w0uldy0u w0uldy0u enabled auto-merge August 31, 2025 06:37
@w0uldy0u w0uldy0u added this pull request to the merge queue Aug 31, 2025
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Aug 31, 2025

Syncing Preview App Succeeded

Application: frontend
Revision: a6a66cb5b1643a13bffcbfd000dda8c2a29ade5f
Health Status: Healthy

Open Preview | View in Argo CD

Merged via the queue into main with commit dc3d076 Aug 31, 2025
10 checks passed
@w0uldy0u w0uldy0u deleted the t2092-adjust-alert-modal-size branch August 31, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants