fix: explicitly define function's output to boolean#15
Merged
skoef merged 1 commit intoskoef:masterfrom Dec 14, 2023
Merged
Conversation
Owner
|
Thanks @ieth0 for this contribution! Could you update the syntax in the examples in README.md as well? |
ieth0
force-pushed
the
fix/bird2-function-void-check
branch
from
34a4e4b to
358be14
Compare
|
Owner
|
@ieth0 there were some linting issues and a test failed, but I'll fix that. Thanks again! |
skoef
added a commit
that referenced
this pull request
Dec 14, 2023
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bird2 complains about function's output if its not set:
/etc/bird.d/match_route.conf:4:14: Inferring function match_route return type from its return value: boolexplicitly defining it prevents unnecessary warning:
https://gitlab.nic.cz/labs/bird/-/blob/v2.14/filter/config.Y?ref_type=tags#L1020