Skip to content

Require rules for optional properties (#18) #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skonves merged 1 commit into from
Nov 6, 2019
Merged

Require rules for optional properties (#18) #19

skonves merged 1 commit into from
Nov 6, 2019

Conversation

@skonves
Copy link
Owner

@skonves skonves commented Nov 6, 2019

fixes #18

@coveralls
Copy link

coveralls commented Nov 6, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 90

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.961%
Totals Coverage Status
Change from base Build 86: 0.0%
Covered Lines: 678
Relevant Lines: 688
💛 - Coveralls

@skonves skonves merged commit 7862816 into master Nov 6, 2019
@skonves skonves deleted the define branch November 6, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optional properties do not require rules in "define"

3 participants

@skonves @coveralls