Update for .NET 9 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated PagedList constructor to initialize Data with an empty array instead of a List. - Simplified null check for query parameter in PageBy method using ArgumentNullException.ThrowIfNull.
Added nullability annotations and default value assignments across multiple classes to improve code safety. Enabled nullable reference types in `Directory.Build.props`. Updated properties in `AuditLog.cs`, `ProductDto.cs`, and others to use default values and nullable types. Refactored `AuditEventLogger` constructor for better readability and modified `AddAuditLogging` methods to accept nullable parameters. Overall, these changes enhance robustness and clarity in property usage.
- Introduced a new project section for "Solution Items" in the solution file, referencing `Directory.Build.props` and `Directory.Packages.props`. - Refactored the `PrepareDefaultConfiguration` method in `AuditEventLogger.cs` to be a static method.
The README.md file has been updated to indicate that the project is now ported to .NET 9, replacing the previous reference to .NET 8. Additionally, the README.md file has been added to the solution items in the Skoruba.AuditLogging.sln file to ensure it is part of the project structure.
Owner
|
Nice PR! Thank you. |
- Updated `Directory.Packages.props` with new package versions for `Microsoft.AspNetCore.OpenApi`, `Microsoft.EntityFrameworkCore`, and related libraries. - Removed a return statement in `AuditLoggingRepository.cs`, indicating potential changes in data processing. - Modified the constructor in `AuditController.cs` for improved dependency injection readability. - Restructured `Program.cs` to adopt a minimal hosting model, enhancing startup configuration and performance. - Added a package reference for `Microsoft.AspNetCore.OpenApi` in `Skoruba.AuditLogging.Host.csproj` for OpenAPI support. - Removed `Startup.cs` and integrated its functionality into `Program.cs`, streamlining the application structure. - Overall, these changes modernize the codebase and align it with current ASP.NET Core best practices.
Author
awesome, will be waiting for your feedback. |
Owner
|
I will do it soon, sry for delay :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project is now ported to .NET 9.