adding +x permissions to bin files for rootless compatbility#4
Open
dsashidh wants to merge 2 commits into
Open
adding +x permissions to bin files for rootless compatbility#4dsashidh wants to merge 2 commits into
dsashidh wants to merge 2 commits into
Conversation
skpark-rh
requested changes
Jun 4, 2026
Owner
skpark-rh
left a comment
skpark-rh
left a comment
There was a problem hiding this comment.
Overall the permission issue persists because the same person can be two different users. This would exacerbate the problem not solve it.
Comment on lines
+172
to
+175
| # Ensure all executables have +x permissions before ownership change | ||
| RUN find /home/devuser/miniconda/bin -type f -exec chmod +x {} + 2>/dev/null || true \ | ||
| && find /home/devuser/.local/bin -type f -exec chmod +x {} + 2>/dev/null || true | ||
|
|
Owner
There was a problem hiding this comment.
I don't think this does anything. By default all the files that are in bin are executables.
| - | | ||
| if [ ! -d /mnt/data/miniconda ]; then | ||
| cp -r --no-preserve=all /home/devuser/. /mnt/data/ | ||
| cp -a /home/devuser/. /mnt/data/ |
Owner
There was a problem hiding this comment.
The -a in cp preserves symlink, permission, ownership, timestamps, context, links, and xattr. This is not what we want to do for agnostic file copies in the nfs.
| - | | ||
| if [ ! -d /mnt/data/miniconda ]; then | ||
| cp -r --no-preserve=all /home/devuser/. /mnt/data/ | ||
| cp -a /home/devuser/. /mnt/data/ |
| - | | ||
| if [ ! -d /mnt/data/miniconda ]; then | ||
| cp -r --no-preserve=all /home/devuser/. /mnt/data/ | ||
| cp -a /home/devuser/. /mnt/data/ |
| - | | ||
| if [ ! -d /mnt/data/miniconda ]; then | ||
| cp -r --no-preserve=all /home/devuser/. /mnt/data/ | ||
| cp -a /home/devuser/. /mnt/data/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makes sure miniconda and local bin files have +x permissions in the image so cp -a preserves them to NFS (i have another PR for the deployment files too)