feat: Application metrics and support undefined metrics#53
Merged
nickschuch merged 7 commits intomainfrom Apr 14, 2026
Merged
Conversation
nterbogt
commented
Apr 13, 2026
| google.protobuf.Timestamp timestamp = 1; // The timestamp of the metric.. | ||
| double value = 2; // The value of the metric at the given timestamp. | ||
| google.protobuf.Timestamp timestamp = 1; // The timestamp of the metric. | ||
| optional double value = 2; // The value of the metric at the given timestamp. |
Contributor
Author
There was a problem hiding this comment.
optional here is to support 0 being different from undefined. Nothing currently uses it, but I didn't want to do the 3 repo update again to change it later :)
nickschuch
reviewed
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.