Skip to content

Chore - remove "use_table_report" config parameter#1973

Merged
jeromedockes merged 7 commits intoskrub-data:mainfrom
rcap107:chore-remove-patch-display-config
Mar 18, 2026
Merged

Chore - remove "use_table_report" config parameter#1973
jeromedockes merged 7 commits intoskrub-data:mainfrom
rcap107:chore-remove-patch-display-config

Conversation

@rcap107
Copy link
Copy Markdown
Member

@rcap107 rcap107 commented Mar 17, 2026

Description

This PR removes the "use_table_report" configuration parameter. This config parameter is patching over the default behavior of pandas and polars dataframes in a non-transparent way.

Given it is a big change, it's better if the user changes this using patch_display and unpatch_display instead.

For the moment I have kept the data ops version of this parameter, but maybe we should remove both.

@rcap107 rcap107 changed the title Chore remove patch display config Chore - remove "use_table_report" config parameter Mar 17, 2026
@rcap107 rcap107 marked this pull request as ready for review March 17, 2026 13:25
@jeromedockes
Copy link
Copy Markdown
Member

For the moment I have kept the data ops version of this parameter, but maybe we should remove both.

they are of a different nature:

  • use_table_report_data_ops decides if skrub itself should use the table report when it generates a display for a skrub dataop. I think it's ok to keep.
  • use_table_report when set to true will monkey-patch methods on pandas.DataFrame and polars.DataFrame, which goes beyond configuring skrub itself and we decided to remove, as you did in this PR 👍

@rcap107 rcap107 added this to the Release 0.8.0 milestone Mar 18, 2026
Comment thread skrub/_reporting/tests/test_patch_display.py
@jeromedockes jeromedockes merged commit 24c4466 into skrub-data:main Mar 18, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CHORE - remove the configuration entry that is setting the patch display

2 participants