Skip to content

Update pydocstyle in pre-commit config#108

Merged
RNKuhns merged 4 commits into
sktime:mainfrom
RNKuhns:fix_pre_commit_pydocstyle
Jan 23, 2023
Merged

Update pydocstyle in pre-commit config#108
RNKuhns merged 4 commits into
sktime:mainfrom
RNKuhns:fix_pre_commit_pydocstyle

Conversation

@RNKuhns
Copy link
Copy Markdown
Contributor

@RNKuhns RNKuhns commented Jan 13, 2023

Reference Issues/PRs

There was a commit in pydocstyle v6.2.3 that has since been reverted. Version 6.2.4 has not yet been released, so this reverts back to 6.2.2.

Also updating additional dependency section to make use of extra dependency installation. Note that pydocstyle switched to using tomli/tomllib for toml parsing instead of toml. Their "extra" install maps this automatically.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.93%. Comparing base (929314d) to head (532f055).
Report is 339 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #108   +/-   ##
=======================================
  Coverage   77.93%   77.93%           
=======================================
  Files          23       23           
  Lines        1867     1867           
=======================================
  Hits         1455     1455           
  Misses        412      412           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly
Copy link
Copy Markdown
Contributor

fkiraly commented Jan 13, 2023

There was a commit in pydocstyle v6.2.3 that has since been reverted. Version 6.2.4 has not yet been released, so this reverts back to 6.2.2.

Sorry, I don't get this, could you kindly explain? Is the commit in pydocstyle itself, or in this or another repo, in relation to pydocstyle?

@RNKuhns
Copy link
Copy Markdown
Contributor Author

RNKuhns commented Jan 14, 2023

@fkiraly the issue is in pydocstyle itself. They already have a fix, but it is not released yet. So this is using prior patch version until the new one is out.

While reading their documentation, I also saw their change with toml parsing and figured I'd update to follow their suggested approach for installing their optional dependency.

Copy link
Copy Markdown
Contributor

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so some bug with 6.2.3. Fine with me then.
(I thought it was about sth in this repo)

@RNKuhns RNKuhns merged commit 471000d into sktime:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants