[MNT] Handle updates to pre-commit linters#120
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 77.93% 77.93%
=======================================
Files 23 23
Lines 1867 1867
=======================================
Hits 1455 1455
Misses 412 412
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fkiraly
approved these changes
Jan 24, 2023
Contributor
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
Sorry, thought I already approved this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes error in #119.
What does this implement/fix? Explain your changes.
There were changes in a few of the linters used in
skbase's continuous integration process.pydocstylemoved to the use oftomliortomllibfor parsing pyproject.toml files (we are going to usetomlisincetomllibis not available in older Python versions)flake8-bugbearvalidation B028 was catching cases of manual quotes in string formatting. It caused [pre-commit.ci] pre-commit autoupdate #119 to fail.flake8-bugbearhas since moved this to an optional validation. This enables that validation, along with two others. And fixes the resulting items flagged by the CI.flake8-bugbearreadme has a description. This PR includes fixes issues identified by B904.