[ENH] Add util tests#125
Closed
RNKuhns wants to merge 8 commits into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
==========================================
- Coverage 81.93% 81.66% -0.27%
==========================================
Files 30 31 +1
Lines 2236 2280 +44
==========================================
+ Hits 1832 1862 +30
- Misses 404 418 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| from skbase.base._meta import BaseMetaObject | ||
|
|
||
|
|
||
| class SomeClass(BaseObject): |
Check warning
Code scanning / CodeQL
`__eq__` not overridden when adding attributes
| self.z = z | ||
|
|
||
|
|
||
| class MetaObjectTester(BaseMetaObject, BaseObject): |
Check warning
Code scanning / CodeQL
`__eq__` not overridden when adding attributes
Contributor
Author
|
Didn't realize I had branched from the branch where I was working on changes to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Completes the portion of #49 and #19 for the
skbase.utilssubmodule. Note that I've included docstring examples for the functions even if they aren't public because I think it is helpful for developers to be able to get a quick glimpse of what the function does.What does this implement/fix? Explain your changes.
The changes reflect:
skbase.utils(functions are tested further in tests of their downstream uses)skbase.utilsfunctionality (I believe these all now comply withnumpydocstandard and have examples)Does your contribution introduce a new dependency? If yes, which one?
No new dependencies.
What should the reviewer focus their review on
I believe I added reasonable tests of the basic functionality of these utils (they are implicitly further tested in their downstream uses). So the key thing is whether you agree with the renaming to make the functionality non-public (i.e., not part of public API). Let me know if any of the functions in
skbase.utils._iter.pyorskbase.utils._nested_iter.pyseem like something we want to include in the public API. Happy to switch the naming convention and add them to the API Reference.PR checklist
For all contributions
the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions