[BUG] Fix type error bug#130
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 81.93% 82.03% +0.10%
==========================================
Files 30 30
Lines 2236 2249 +13
==========================================
+ Hits 1832 1845 +13
Misses 404 404
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@fkiraly this should be ready for review. |
fkiraly
left a comment
There was a problem hiding this comment.
Looks good to me.
I have a gut feeling that there might probably already be a method that does _remove_type_text, but I don't know, so fine with me.
My main design comment would be, test_type_validations, especially test_check_sequence_output looks like there is a lot of repetition that could be covered by pytest.mark.parametrize, but not a blocker for me.
Reference Issues/PRs
Fixes #129.
What does this implement/fix? Explain your changes.
Error referenced in #129 was being raised through
skbase.utils.check_sequence. This cleans up the error messaging there and in other type checking utility functions. They now raiseTypeErrors and use a utility function to remove boilerplate "" when converting classes to strings.Does your contribution introduce a new dependency? If yes, which one?
None.
What should a reviewer concentrate their feedback on?
Change in error messages.
Any other comments?
PR checklist
For all contributions
the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions