[ENH] tag manager mixin#138
Merged
Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #138 +/- ##
==========================================
+ Coverage 82.43% 82.64% +0.20%
==========================================
Files 31 32 +1
Lines 2289 2316 +27
==========================================
+ Hits 1887 1914 +27
Misses 402 402
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
Addressed, see replies in #140 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
port of sktime/sktime#3630 to
skbaseThis PR factors out the tag management logic into a
_FlagManagermixin, and generalizes the functionality so it can be used for multiple fields of tags.Advantages:
BaseObjectclass: state/parameter management and tag managementset_configsimilar to the newsklearnfeatureTest coverage is already there for the base case, but should be added for a different tag field. Will do that with the PR that adds config handling.
(I called the flag manager since not all flags are tags, and interactions with the sklearn
_get_tags)A STEP is available here: sktime/enhancement-proposals#29