[MNT] remove dependency on typing-extensions#167
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+47
to
+82
| # class ClassInfo(TypedDict): | ||
| # """Type definitions for information on a module's classes.""" | ||
|
|
||
| klass: Type | ||
| name: str | ||
| description: str | ||
| tags: MutableMapping[str, Any] | ||
| is_concrete_implementation: bool | ||
| is_base_class: bool | ||
| is_base_object: bool | ||
| authors: Optional[Union[List[str], str]] | ||
| module_name: str | ||
| # klass: Type | ||
| # name: str | ||
| # description: str | ||
| # tags: MutableMapping[str, Any] | ||
| # is_concrete_implementation: bool | ||
| # is_base_class: bool | ||
| # is_base_object: bool | ||
| # authors: Optional[Union[List[str], str]] | ||
| # module_name: str | ||
|
|
||
|
|
||
| class FunctionInfo(TypedDict): | ||
| """Information on a module's functions.""" | ||
| # class FunctionInfo(TypedDict): | ||
| # """Information on a module's functions.""" | ||
|
|
||
| func: FunctionType | ||
| name: str | ||
| description: str | ||
| module_name: str | ||
| # func: FunctionType | ||
| # name: str | ||
| # description: str | ||
| # module_name: str | ||
|
|
||
|
|
||
| class ModuleInfo(TypedDict): | ||
| """Module information type definitions.""" | ||
| # class ModuleInfo(TypedDict): | ||
| # """Module information type definitions.""" | ||
|
|
||
| path: str | ||
| name: str | ||
| classes: MutableMapping[str, ClassInfo] | ||
| functions: MutableMapping[str, FunctionInfo] | ||
| __all__: List[str] | ||
| authors: str | ||
| is_package: bool | ||
| contains_concrete_class_implementations: bool | ||
| contains_base_classes: bool | ||
| contains_base_objects: bool | ||
| # path: str | ||
| # name: str | ||
| # classes: MutableMapping[str, ClassInfo] | ||
| # functions: MutableMapping[str, FunctionInfo] | ||
| # __all__: List[str] | ||
| # authors: str | ||
| # is_package: bool | ||
| # contains_concrete_class_implementations: bool | ||
| # contains_base_classes: bool | ||
| # contains_base_objects: bool |
Check notice
Code scanning / CodeQL
Commented-out code
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #167 +/- ##
==========================================
- Coverage 82.82% 82.62% -0.21%
==========================================
Files 39 39
Lines 2795 2762 -33
==========================================
- Hits 2315 2282 -33
Misses 480 480
|
fkiraly
added
the
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes
skbase's dependency ontyping-extensionswhich was only punctually used.Rationale is minimizing dependencies.