Skip to content

[ENH] turn off check in BaseObject.clone#176

Merged
fkiraly merged 1 commit into
mainfrom
turn-off-clone-check
May 4, 2023
Merged

[ENH] turn off check in BaseObject.clone#176
fkiraly merged 1 commit into
mainfrom
turn-off-clone-check

Conversation

@fkiraly
Copy link
Copy Markdown
Contributor

@fkiraly fkiraly commented May 4, 2023

This PR turns off the check in BaseObject.clone, which unintentionally couples clone to pytest, via import of deep_equals that imports pytest by accident (through __init__).

This can be done without deprecation, ahead of a refactor that moves deep_equals out of the testing module.

Fast fix for #177 but does not address it finally (if check_clone config is True, the bug still occurs)

@fkiraly fkiraly added the bug Something isn't working label May 4, 2023
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 4, 2023

Codecov Report

Merging #176 (a6e1772) into main (9a5c70c) will decrease coverage by 0.26%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
- Coverage   82.89%   82.64%   -0.26%     
==========================================
  Files          39       39              
  Lines        2777     2777              
==========================================
- Hits         2302     2295       -7     
- Misses        475      482       +7     
Impacted Files Coverage Δ
skbase/base/_base.py 80.06% <ø> (ø)

... and 1 file with indirect coverage changes

@fkiraly fkiraly merged commit 6d68a92 into main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants