Skip to content

[MNT] test for isolation of developer dependencies, and basic pytest-less test for BaseObject#179

Merged
fkiraly merged 6 commits into
mainfrom
nopytest-test
May 4, 2023
Merged

[MNT] test for isolation of developer dependencies, and basic pytest-less test for BaseObject#179
fkiraly merged 6 commits into
mainfrom
nopytest-test

Conversation

@fkiraly
Copy link
Copy Markdown
Contributor

@fkiraly fkiraly commented May 4, 2023

This adds basic tests to ensure isolation from developer dependencies including pytest outside of test modules, and adds a basic pytest-less test for BaseObject.

The approach is as follows:

  • addition of a new GHA job
  • only skbase plain is installed, no dev dependencies
  • a test file _nopytest_tests is added, which can contain pytest-free checks
  • all_objects plain is executed. As this crawls all modules (except tests and a few others), it will spot unisolated developer dependency imports
  • parameterless methods of BaseObject are executed on an instance. This ensures those methods are isolated, and it would also catch the issue with clone described here: [BUG] clone breaks when skbase is installed without pytest #177

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label May 4, 2023
@fkiraly fkiraly merged commit d572656 into main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant