[MNT] test for isolation of developer dependencies, and basic pytest-less test for BaseObject#179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds basic tests to ensure isolation from developer dependencies including
pytestoutside of test modules, and adds a basicpytest-less test forBaseObject.The approach is as follows:
skbaseplain is installed, nodevdependencies_nopytest_testsis added, which can containpytest-free checksall_objectsplain is executed. As this crawls all modules (except tests and a few others), it will spot unisolated developer dependency importsBaseObjectare executed on an instance. This ensures those methods are isolated, and it would also catch the issue withclonedescribed here: [BUG]clonebreaks whenskbaseis installed withoutpytest#177