[BUG] fix faulty suppress_import_stdout in all_objects#193
Merged
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #193 +/- ##
==========================================
- Coverage 82.75% 82.66% -0.09%
==========================================
Files 43 43
Lines 2806 2810 +4
==========================================
+ Hits 2322 2323 +1
- Misses 484 487 +3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the faulty
suppress_import_stdoutinall_objects.Instead of always restoring the
stdoutafter suppression to its initial state, it would instead set it to the terminal, no matter where it previously was (e.g., a jupyter notebook).Further, it would also not be reset if an exception was encountered, which is now also handled.
This fixes the error in sktime/sktime#4692 by manual testing, although I'm not sure how one would test for this in CI.