[ENH] informative failure message in test_get_package_metadata_returns_expected_results#239
Merged
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
- Coverage 83.68% 83.62% -0.07%
==========================================
Files 41 41
Lines 2820 2834 +14
==========================================
+ Hits 2360 2370 +10
- Misses 460 464 +4
☔ View full report in Codecov by Sentry. |
fkiraly
pushed a commit
that referenced
this pull request
Oct 26, 2023
This PR improves the `deep_equals` utility by introducing the ability to provide custom plugins. Ultimately, this enables more flexibility in soft dependencies for data containers such as `polars` (see, e.g., sktime/sktime#5423) throughout the `sktime` package ecosystem, as `deep_equals` is used for extrinsic testing and validity checking. Similarly, the `ForecastingHorizon` check should be moved as a plugin into `sktime`. In addition, makes the following changes: * splits up the `deep_equals` file into a module with multiple files Depends on #239.
fkiraly
added a commit
that referenced
this pull request
Mar 1, 2024
PR #239 changes the type of exception raised by `get_test_params` to `ValueError`, which is an unintended side effect of the imprroved error feedback. This can lead to breakage in exception handling, e.g., in `sktime` tests for exception handling on top. This PR ensures the type of exception is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far,
test_get_package_metadata_returns_expected_resultshas failed in every attempt to make a proper PR toscikit-base, due to the design decision of using the package itself as a test case forall_objects- so adding any function or class anywhere without making a corresponding change in a register will fail the test.Apart from that this needs to change, as a short term measure a more helpful error message should allow developers to find the place to add the expected functions or classes.
This PR adds these error messages.