Skip to content

[BUG] fix deep_equals for np.array with dtype="object"#263

Merged
fkiraly merged 1 commit into
mainfrom
deep_equals-object-nan
Jan 12, 2024
Merged

[BUG] fix deep_equals for np.array with dtype="object"#263
fkiraly merged 1 commit into
mainfrom
deep_equals-object-nan

Conversation

@fkiraly
Copy link
Copy Markdown
Contributor

@fkiraly fkiraly commented Jan 4, 2024

This PR fixes an unreported bug where deep_equals would break on np.array with dtype="object", this is due to the equal_nan=True setting in np.array_equal which will lead to an exception if dtype="object"`.

Also includes test cases covering this.

Mirror of sktime/sktime#5697 (duplicated prior to ongoing refactor)

@fkiraly fkiraly added bug Something isn't working implementing framework Implementing core skbase framework labels Jan 4, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3bb51d8) 84.65% compared to head (a5a3846) 84.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
+ Coverage   84.65%   84.69%   +0.04%     
==========================================
  Files          43       43              
  Lines        2926     2928       +2     
==========================================
+ Hits         2477     2480       +3     
+ Misses        449      448       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fkiraly fkiraly merged commit 53b35a8 into main Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working implementing framework Implementing core skbase framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant