[ENH] all_objects filter_tags to function with list-of tags#273
Merged
Conversation
fkiraly
added
implementing framework
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #273 +/- ##
==========================================
+ Coverage 84.69% 84.71% +0.01%
==========================================
Files 43 43
Lines 2928 2931 +3
==========================================
+ Hits 2480 2483 +3
Misses 448 448 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
all_objectsbreaks iffilter_tagsis set and some tags in estimators are lists, as lists are unhashable.This PR changes behaviour in the case of iterable tag value from raising an exception (unhashable list) to the condition that at least one search value is among the tag values.
Fixes first item in sktime/sktime#5755