Skip to content

[MNT] rename testing.utils.inspect to avoid shadowing of inspect#316

Merged
fkiraly merged 6 commits into
mainfrom
exclude-inspect
Apr 16, 2024
Merged

[MNT] rename testing.utils.inspect to avoid shadowing of inspect#316
fkiraly merged 6 commits into
mainfrom
exclude-inspect

Conversation

@fkiraly
Copy link
Copy Markdown
Contributor

@fkiraly fkiraly commented Apr 16, 2024

This PR renames to testing.utils.inspect module to _inspect, in order to avoid shadowing of inspect, and the flake8 errors caused by this.

Deprecation is not necessary, as the module - while not having a private name itself - contains only private objects.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Apr 16, 2024
@fkiraly fkiraly merged commit 139edac into main Apr 16, 2024
fkiraly added a commit that referenced this pull request Apr 17, 2024
…nspect`" (#319)

Reverts #316 - `skpro` was importing the private utility.

Reverting until resolved, adds a flake exception for the offending file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Continuous integration, unit testing & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant