[ENH] ensure _get_installed_packages does not break in case of empty package metadata#461
Merged
fkiraly merged 2 commits intosktime:mainfrom Nov 14, 2025
Merged
Conversation
for more information, see https://pre-commit.ci
fkiraly
requested changes
Oct 29, 2025
Contributor
fkiraly
left a comment
There was a problem hiding this comment.
Thanks!
Is there any way to test this, e.g., with pytest patch or similar?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #461 +/- ##
==========================================
+ Coverage 85.07% 85.94% +0.86%
==========================================
Files 45 50 +5
Lines 3015 3585 +570
==========================================
+ Hits 2565 3081 +516
- Misses 450 504 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fkiraly
approved these changes
Nov 14, 2025
Contributor
fkiraly
left a comment
There was a problem hiding this comment.
I think it is fine like this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
#433
What does this implement/fix? Explain your changes.
Some broken packages with empty
.egg-infofolder, will result in empty metadata, which will giveNoneas pkg name and causeValueError("A distribution name is required.")inDistribution.from_nameAdded some simple filters to ignore them.
Does your contribution introduce a new dependency? If yes, which one?
No
What should a reviewer concentrate their feedback on?
Any other comments?
PR checklist
For all contributions
the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions